fix: redact sensitive info in logs and fix strict type violations#70
Merged
nicknisi merged 5 commits intoworkos:mainfrom Feb 24, 2026
Merged
Conversation
- Replace `as ArgumentsCamelCase<InstallArgs>` with argv spread in bin.ts - Use identity builder for env list command to inherit parent options - Remove dead `if (!str)` guard in redactSensitiveInfo - Consolidate duplicate InstallerArgs type into single export from run.ts - Tighten client ID redaction regex to avoid false positives
Member
|
@Rayhan1967 Thanks for this! I made a few minor changes, mostly around formatting to appease CI. I appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two critical issues identified in the codebase:
as anyandas unknownusage, replacing them with proper TypeScript interfaces and type-only imports to adhere to the project's strict typing standards.Changes
src/utils/clack-utils.tsto include aredactSensitiveInfoutility.src/utils/clack-utils.ts'sinstallPackagefunction.src/bin.tsandsrc/commands/install.tsto use proper types instead ofas any.InstallArgsfor proper type-safety in the CLI entry point.