New package: thextech-1.3.7.2#59005
Conversation
|
About ARM (According to the author of the program)
|
|
Attempt to fix build on arm7l (Failed) |
|
Update: It can be build on |
|
Update: Now it can build on: |
| short_desc="Modern C++ port and successor of the SMBX engine" | ||
| maintainer="SkullGamer205 <skullgamer205@disroot.org>" | ||
| license=GPL-3.0 | ||
| homepage="wohlsoft.ru/projects/thextech" |
There was a problem hiding this comment.
Oh. Letter case matters. Sorry. My typo.
| pkgname=thextech | ||
| version=1.3.7.2 | ||
| revision=1 | ||
| _subversion=1 # hotfix |
There was a problem hiding this comment.
This should probably be included in the version.
There was a problem hiding this comment.
The versioning system will be significantly changed in the near future. The number 3 will be removed.
But IDK how implement hotfix into version.
| case "$XBPS_TARGET_MACHINE" in | ||
| armv[67]*) | ||
| msg_normal "Detected ARM architecture ("$XBPS_TARGET_MACHINE")\n" | ||
| for x in ${FILESDIR}/patches/arm-disable-opus.patch; do |
There was a problem hiding this comment.
We usually try to avoid conditional patches.
There was a problem hiding this comment.
This patch is used specifically for building on architectures where building fails. However, a patch is currently being developed (which I backport) that will automatically check the architecture, and this code may no longer be necessary.
| } | ||
|
|
||
| post_install() { | ||
| rm -rf ${DESTDIR}/builddir |
There was a problem hiding this comment.
this should not be necessary, xbps-src clean should clean the builddir, rm -rf'ing it here interfers with xbps-src -C and potentially builddirs of other packages..
| configure_args="-DPGE_SHARED_SDLMIXER=OFF -DUSE_SYSTEM_SDL2=ON -DUSE_FREEIMAGE_SYSTEM_LIBS=ON -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=MinSizeRel" | ||
| hostmakedepends="pkg-config git cmake ninja" | ||
| makedepends="SDL2-devel libpng-devel libjpeg-turbo-devel alsa-lib-devel" | ||
| depends="SDL2 libjpeg-turbo libpng" |
There was a problem hiding this comment.
Dependencies should be detected automatically by xbps-src which adds minimum version requirements, listing them here will overwrite that.
| depends="SDL2 libjpeg-turbo libpng" | ||
| short_desc="Modern C++ port and successor of the SMBX engine" | ||
| maintainer="SkullGamer205 <skullgamer205@disroot.org>" | ||
| license=GPL-3.0 |
There was a problem hiding this comment.
License should by an SPDX identifier, either GPL-3.0-only or GPL-3.0-or-later.
| revision=1 | ||
| _subversion=1 # hotfix | ||
| build_style=cmake | ||
| configure_args="-DPGE_SHARED_SDLMIXER=OFF -DUSE_SYSTEM_SDL2=ON -DUSE_FREEIMAGE_SYSTEM_LIBS=ON -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=MinSizeRel" |
There was a problem hiding this comment.
-DCMAKE_INSTALL_PREFIX is already sset by the cmake build style. -DDCMAKE_BUILD_TYPE too, its set to None so that xbps-src compiler flags are used.
Testing the changes
New package
Local build testing