Conversation
Member
Author
|
Created #583 to cover the still needed debouncing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were running into performance issues for "large" prefix queries.
When I user types
fs2 S, perhaps on their way to typingfs2 Stream, we rewrite this query tofs2 (S OR S*).This means we end up with something like
fs2 OR S OR ....every term in the whole collection starting with S..., this can be quite large.One approach to addressing this, that we likely should still do, is to debounce search on input.
However, the javascript to do this was escaping me.
So I opted to improve the performance of
fs2 Supstream by 135x for now 😆 😬