Fix run.taskIdentifier being reported as "unknown" for batch triggers by bharathkumar39293 · Pull Request #2974 · triggerdotdev/trigger.dev

bharathkumar39293 · 2026-01-30T06:53:11Z

Closes #2942
This PR fixes an issue where run.taskIdentifier was reported as "unknown" when using batch.triggerAndWait / batch.triggerByTaskAndWait.

The root cause was that taskIdentifier was not propagated from the platform to the worker via the
CompletedWaitpoint
, causing the runtime to fall back to "unknown".

Changes
Schema

Added taskIdentifier to the
CompletedWaitpoint
schema (
packages/core/src/v3/schemas/runEngine.ts
)
Platform

Updated
ExecutionSnapshotSystem
to:
Select taskIdentifier from the database
Map it onto the
CompletedWaitpoint
sent to the worker (
internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts
)
Worker

Updated
SharedRuntimeManager
to use waitpoint.completedByTaskRun.taskIdentifier when constructing the execution result (
packages/core/src/v3/runtime/sharedRuntimeManager.ts
)
Added a backward-compatible fallback to "unknown" for legacy runs
Verification
Unit Tests
Added
packages/core/src/v3/runtime/sharedRuntimeManager.test.ts
covering:
Correct propagation of taskIdentifier when present
Graceful fallback to "unknown" when missing
All tests are passing.

changeset-bot · 2026-01-30T06:53:15Z

🦋 Changeset detected

Latest commit: 7f138d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@trigger.dev/core	Patch
@trigger.dev/build	Patch
trigger.dev	Patch
@trigger.dev/python	Patch
@trigger.dev/redis-worker	Patch
@trigger.dev/schema-to-json	Patch
@trigger.dev/sdk	Patch
@internal/cache	Patch
@internal/clickhouse	Patch
@internal/redis	Patch
@internal/replication	Patch
@internal/run-engine	Patch
@internal/schedule-engine	Patch
@internal/testcontainers	Patch
@internal/tracing	Patch
@internal/tsql	Patch
@internal/zod-worker	Patch
d3-chat	Patch
references-d3-openai-agents	Patch
references-nextjs-realtime	Patch
references-realtime-hooks-test	Patch
references-realtime-streams	Patch
references-telemetry	Patch
@internal/sdk-compat-tests	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/rsc	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-30T06:53:29Z

Walkthrough

The PR threads a new taskIdentifier from completed waitpoints through the execution snapshot system and related runtime code. Prisma queries for snapshots and chunked waitpoint fetches now include completedByTaskRun.select.taskIdentifier. Types and helper signatures were updated to carry taskIdentifier through EnhancedExecutionSnapshot and public snapshot mappings. SharedRuntimeManager‘s waitpoint-to-task-run conversion now emits taskIdentifier (defaults to "unknown" if absent). The CompletedWaitpoint schema adds an optional completedByTaskRun.taskIdentifier. Unit tests for the conversion method were added and a changeset was created.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately and specifically describes the main fix: resolving the taskIdentifier being reported as 'unknown' for batch triggers, which directly addresses the core issue.
Description check	✅ Passed	The PR description includes the linked issue reference, clear explanation of the root cause, organized changes across schema/platform/worker layers, and verification details with unit tests.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#2942` by implementing taskIdentifier propagation through CompletedWaitpoint schema updates, ExecutionSnapshotSystem database queries, and SharedRuntimeManager with backward-compatible fallback.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the taskIdentifier propagation for batch triggers, with no unrelated modifications detected in the files changed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99192b6 and fe7e5ed.

📒 Files selected for processing (2)

.changeset/fix-batch-trigger-task-identifier.md
packages/core/src/v3/runtime/sharedRuntimeManager.ts

🚧 Files skipped from review as they are similar to previous changes (1)

packages/core/src/v3/runtime/sharedRuntimeManager.ts

🧰 Additional context used

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerByTaskAndWait()` to batch trigger tasks by passing task instances and wait for results

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Export tasks with unique IDs within the project to enable proper task discovery and execution

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `yourTask.batchTrigger()` to trigger multiple runs of a task from inside another task

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `yourTask.batchTriggerAndWait()` to batch trigger tasks and wait for all results from a parent task

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `tasks.batchTrigger()` to trigger multiple runs of a single task with different payloads

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerAndWait()` to batch trigger multiple different tasks and wait for results

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerByTask()` to batch trigger tasks by passing task instances for static task sets

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Attach metadata to task runs using the metadata option when triggering, and access/update it inside runs using metadata functions

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use the `task()` function from `trigger.dev/sdk/v3` to define tasks with id and run properties

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.trigger()` to trigger multiple different tasks at once from backend code

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Export tasks with unique IDs within the project to enable proper task discovery and execution

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerByTask()` to batch trigger tasks by passing task instances for static task sets

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `yourTask.batchTrigger()` to trigger multiple runs of a task from inside another task

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `tasks.batchTrigger()` to trigger multiple runs of a single task with different payloads

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2026-01-15T11:50:06.067Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-15T11:50:06.067Z
Learning: Applies to **/*.{ts,tsx} : Every Trigger.dev task must be exported and have a unique `id` property with no timeouts in the run function

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use the `task()` function from `trigger.dev/sdk/v3` to define tasks with id and run properties

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerByTaskAndWait()` to batch trigger tasks by passing task instances and wait for results

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.trigger()` to trigger multiple different tasks at once from backend code

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `yourTask.batchTriggerAndWait()` to batch trigger tasks and wait for all results from a parent task

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

📚 Learning: 2025-11-27T16:27:35.304Z

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `batch.triggerAndWait()` to batch trigger multiple different tasks and wait for results

Applied to files:

.changeset/fix-batch-trigger-task-identifier.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)

GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
GitHub Check: sdk-compat / Node.js 22.12 (ubuntu-latest)
GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
GitHub Check: sdk-compat / Cloudflare Workers
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: sdk-compat / Deno Runtime
GitHub Check: sdk-compat / Bun Runtime
GitHub Check: typecheck / typecheck
GitHub Check: sdk-compat / Node.js 20.20 (ubuntu-latest)

🔇 Additional comments (2)

.changeset/fix-batch-trigger-task-identifier.md (2)

1-3: LGTM: Version bump is appropriate.

The patch version bump for @trigger.dev/core is correct for this bug fix. The changeset format follows the standard convention.

1-5: No action needed. The changeset correctly lists only @trigger.dev/core. Changes to @internal/run-engine do not require a changeset entry because that package is marked as private: true and is not published to npm.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2026-01-30T06:56:48Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

bharathkumar39293 · 2026-02-04T12:10:52Z

@ericallam I've updated the PR with the requested changes:

Fixed the this binding context in waitForBatch by using an arrow function.
Added a changeset.
Ready for review!

devin-ai-integration

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

devin-ai-integration · 2026-02-25T15:06:51Z

internal-packages/run-engine/src/engine/systems/executionSnapshotSystem.ts

+      include: {
+        completedByTaskRun: {
+          select: {
+            taskIdentifier: true,
+          },
+        },
+      },


🚩 Additional Prisma JOINs added to multiple hot query paths

This PR adds include: { completedByTaskRun: { select: { taskIdentifier: true } } } to four separate query paths: getLatestExecutionSnapshot (line 182-190), getExecutionSnapshotCompletedWaitpoints (line 210-218), fetchWaitpointsInChunks (line 161-167), and the ExecutionSnapshotWithCheckAndWaitpoints type (line 34-42). Each of these now performs an extra JOIN to the TaskRun table for every waitpoint. For runs with many waitpoints (e.g., large batches of 1000), this adds 1000 JOINs. The completedByTaskRunId column has a @unique constraint, so the JOIN should be efficient (index lookup), but it's worth monitoring query performance for large batch scenarios.

Was this helpful? React with 👍 or 👎 to provide feedback.

fix(core): propagate taskIdentifier for batch triggers

c6c4ce7

devin-ai-integration bot reviewed Jan 30, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

bharathkumar39293 and others added 3 commits January 30, 2026 12:42

chore(test): remove mocks

99192b6

Merge branch 'main' into fix/batch-trigger-task-identifier

7727737

Merge branch 'main' into fix/batch-trigger-task-identifier

7af5dd6

This comment was marked as resolved.

Sign in to view

fix: bind this in waitForBatch and add changeset

fe7e5ed

bharathkumar39293 added 4 commits February 5, 2026 10:45

Merge branch 'main' into fix/batch-trigger-task-identifier

8540138

Merge branch 'main' into fix/batch-trigger-task-identifier

f8819c0

Merge branch 'main' into fix/batch-trigger-task-identifier

31ecd33

Merge branch 'main' into fix/batch-trigger-task-identifier

7f138d1

devin-ai-integration bot reviewed Feb 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Fix run.taskIdentifier being reported as "unknown" for batch triggers#2974

Fix run.taskIdentifier being reported as "unknown" for batch triggers#2974
bharathkumar39293 wants to merge 9 commits intotriggerdotdev:mainfrom
bharathkumar39293:fix/batch-trigger-task-identifier

bharathkumar39293 commented Jan 30, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

changeset-bot bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

vibe-kanban-cloud bot commented Jan 30, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

bharathkumar39293 commented Feb 4, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

devin-ai-integration bot Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

bharathkumar39293 commented Jan 30, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

vibe-kanban-cloud bot commented Jan 30, 2026

Review Complete

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

bharathkumar39293 commented Feb 4, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bharathkumar39293 commented Jan 30, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Jan 30, 2026 •

edited

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading