fix/docs: Clarify Postgres upgrade requirements for Helm#1629
fix/docs: Clarify Postgres upgrade requirements for Helm#1629marcleblanc2 wants to merge 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| ### Standard upgrades | ||
|
|
||
| A [standard upgrade](/self-hosted/updates/#upgrade-types) occurs between a Sourcegraph version and the minor or major version released immediately after it. If you would like to jump forward several versions, you must perform a [multi-version upgrade](#multi-version-upgrades) instead. |
There was a problem hiding this comment.
This can be minor or major -- users on 6.12.0 will be able to standard upgrade to 7.0.0
There was a problem hiding this comment.
I know, but haven't found a less confusing way to phrase it.
| **Step 1:** Review [Helm Changelog] and [Sourcegraph Changelog] and select the most recent version compatible with your current Sourcegraph version. | ||
|
|
||
| <Callout type="warning"> | ||
| You can only upgrade one minor version of Sourcegraph at a time. |
There was a problem hiding this comment.
Why remove this callout? Its true that for standard upgrades you can only go across a minor version
There was a problem hiding this comment.
It's duplicative of the previous callout.
|
|
||
| - Upgrade the 3x Postgres pods to a Sourcegraph v6 version: | ||
|
|
||
| - Deploy a v6 version of either the `sourcegraph` or `sourcegraph-migrator` Helm chart |
There was a problem hiding this comment.
Version 6.0.0 and greater migrators will refuse to connect to a PG12 db. I'm not relying on the migrator job to bring up the dbs and crashloop attempts to connect to them until they complete their PG upgrade will work 🤔
There was a problem hiding this comment.
I've added the database-maintenance-override.yaml example override file to the Helm repo, so customers can use their regular Helm chart and override file, to let the database pods come up on their own to run the upgrade without any other pods trying to connect to them.
Optionally, the override can be used to operate the migrator init container in the frontend pod.
I think the sourcegraph-migrator helm chart should work fine, but I'll test it before merging this.
DaedalusG
left a comment
DaedalusG
left a comment
There was a problem hiding this comment.
Minor comments but this lgtm, I like the call to action to move to external dbs
I do think the approach of using the migrator job chart in the helm repo should be tested before adjusting this callout though
2 participants
The messaging on our Helm upgrade docs for the Postgres v12 -> v16 upgrade is currently inaccurate, causing customer admin confusion, and causing customer admins to waste time running more upgrades than needed.
The decision to remove the Postgres upgrade scripts in v7 compounds this confusion, increasing the need for clarity.
Before
After
