Skip to content

fix: avoid infinite loops when searching for filesystem root of another drive#353

Draft
zimeg wants to merge 7 commits intomainfrom
fix-windows-ci
Draft

fix: avoid infinite loops when searching for filesystem root of another drive#353
zimeg wants to merge 7 commits intomainfrom
fix-windows-ci

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Feb 25, 2026

Changelog

We now exit a few seconds after attempting to flush traces. This fixes an issue where the Windows installation script wouldn't exit after adding this CLI to the environment in certain CI workflows.

Summary

This PR follows #178 with ongoing attempt to exit hanging installations.

Requirements

zimeg and others added 2 commits February 24, 2026 22:24
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg self-assigned this Feb 25, 2026
@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.42%. Comparing base (1059ec2) to head (39faaec).

Files with missing lines Patch % Lines
main.go 0.00% 10 Missing ⚠️
internal/tracer/tracer.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   64.48%   64.42%   -0.07%     
==========================================
  Files         213      213              
  Lines       17879    17891      +12     
==========================================
- Hits        11530    11527       -3     
- Misses       5276     5290      +14     
- Partials     1073     1074       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg changed the title fix: avoid hang before command exit if jaeger traces fail to flush fix: avoid infinite loops when searching for filesystem root of another drive Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant