Feat: adds docs command with optional search flag#352
Open
lukegalbraithrussell wants to merge 7 commits intomainfrom
Open
Feat: adds docs command with optional search flag#352lukegalbraithrussell wants to merge 7 commits intomainfrom
docs command with optional search flag#352lukegalbraithrussell wants to merge 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 64.48% 64.53% +0.04%
==========================================
Files 213 214 +1
Lines 17879 17924 +45
==========================================
+ Hits 11530 11567 +37
- Misses 5276 5281 +5
- Partials 1073 1076 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukegalbraithrussell
changed the title
docs command with optional search paramdocs command with optional search flag
| "github.com/stretchr/testify/mock" | ||
| ) | ||
|
|
||
| func Test_Docs_DocsCommand(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
valid if these are too many tests lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
The
slack docscommand opens the slack docs site; its--searchflag opens the slack docs search page with the provided search query.Summary
This PR adds a
docscommand.slack docsdocs.slack.devslack docs --search "something cool"docs.slack.dev/search/?q=something+coolslack docs --searchdocs.slack.dev**for reviewers: should this instead open
docs.slack.dev/search?This doesn't take advantage of the charm experiment. Next steps though!!!
Requirements