Fix bug in cloud client missing the project id and refactor the package#28
Open
elivlo wants to merge 5 commits intoshapeblue:mainfrom
Open
Fix bug in cloud client missing the project id and refactor the package#28elivlo wants to merge 5 commits intoshapeblue:mainfrom
elivlo wants to merge 5 commits intoshapeblue:mainfrom
Conversation
…e we can set it as default option
Contributor
Author
|
@Pearl1594 I have created a bugfix here and closed the issue in the cloudstack group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The client only uses the project ID in the function
GetVMByIDand not in the functiongetVMByName. This causes the CSI where the instance ID is not found in the metadata and the VM is in a project to fail. Eventually they fall back into a crash loop back off and the CSI is not usable.It refactors all functions of the
cloudpackage to use the default project_id option. This reduces code duplication by using cloudstack clientmethodsthat support the default options. This refactoring is based on the following fix: It fixes the functiongetVMByNameby using the methodGetVirtualMachineByNameinstead ofListVirtualMachines.These changes ensure that the project id is automatically included and makes the code more mature.
Testing performed:
I installed k8s into Cloudstack inside of a project and without. The setup of the CSI worked when running in the root project but not in sub projects with the current version 3.0.0. I am using my PR version currently in a cluster on a Cloudstack instance within a project and with that it is working just fine.
Please create a bugfix release when the PR is approved and merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.