Calculate and add p-value and stddev to summary table#479
Calculate and add p-value and stddev to summary table#479eightbitraptor merged 3 commits intomainfrom
Conversation
Using Welch's t-test for p-values because I don't want to assume that both versions of Ruby tested are going to have equal timing distributions.
|
Could we make it an optional feature like |
|
I'd really like to have some indication of statistical significance every time this is reported. I think that is one of the most important numbers. Maybe if horizontal space is at a premium could just be tagging the last column with |
|
@k0kubun @jhawthorn what about using a single extra column showing an icon depending on whether the p-value is < 0.001, <0.01, <0.05 - and blank otherwise. And then the exact values can be gated behind the Also bear in mind that the example I pasted here also has the |
|
sounds good to me 👍 |
actual p-value still gated behind --pvalue
10a2725 to
bf3b7b3
Compare
|
Ok, fixed, and updated PR description with examples. Thanks both. |
Trying to add some way of determining whether the difference in results from one Ruby to the other could be reproduced by random noise, or if the difference is actually significant.
Using Welch's t-test for p-values because I don't want to assume that both versions of Ruby tested are going to have equal timing distributions.
Full p-value information is gated behind
--pvaluein order to not bloat out the width of the table.Without
--pvalueasterisks will be displayed in the ration column as follows:and will
--pvaluefull details are shown: