clk/bcm2835: Don't allow "osc" as a parent for "dpi"#7259
Draft
6by9 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Draft
clk/bcm2835: Don't allow "osc" as a parent for "dpi"#72596by9 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
6by9 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
DPI being a pixel clock needs to be fairly accurate. BCM2711 has changed the oscillator from 19.2MHz to 54MHz, so the current clock manager code thinks that for eg a 32MHz pixel clock it can use the oscillator and a fractional divider. For many displays this isn't acceptable. Add a new option for clock parentage that doesn't permit the oscillator, and use this option for the DPI clock. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPI being a pixel clock needs to be fairly accurate. BCM2711 has changed the oscillator from 19.2MHz to 54MHz, so the current clock manager code thinks that for eg a 32MHz pixel clock it can use the oscillator and a fractional divider. For many displays this isn't acceptable.
Add a new option for clock parentage that doesn't permit the oscillator, and use this option for the DPI clock.
#7126
Wants testing on their hardware before merge, hence draft.