Support :sql schema format in the install generator#708
Support :sql schema format in the install generator#708ringe wants to merge 2 commits intorails:mainfrom
Conversation
|
I've built a script to run any of the "Tests (3.1, sqlite, rails_7_2)" approaches. The failing tests are not failing because of my patch here, the tests are just not very stable. Can I do anything to make the tests more stable? |
|
Thank you!
Hey! Yes, out of the 3, only one test was actually failing, and that's a flaky test already on my radar. The other two failures were Docker container starting errors from GitHub actions, it seems. I'll try to review this this week, but I'm not sure if I'll get to it 🤞 |
|
Sorry for the delay @ringe, I couldn't get to this until this week. Unfortunately, this is not going to work as it is, because your structure.sql file is not compatible with PostgreSQL. The advantage of I think to support this, the structure.sql file can't be provided as a template; it should be generated as part of the install based on the app's configuration. |
This patch will make it easier to use
solid_queuewhen the app is set up with:sqlschema format because of unsupported SQL features.Fixes #621
active_record.schema_formatqueue_structure.sqltemplate based on the existingqueue_schema.rbtemplate