Skip to content

Handle malformed release versions in docs versions view #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityagiri3600 wants to merge 2 commits into from
+12 −0
Closed

Handle malformed release versions in docs versions view #2935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9897f96
Handle malformed release versions in docs versions view
adityagiri3600 Feb 22, 2026
8be035e
Avoid magic number in docs version guard
adityagiri3600 Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pydotorg/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,13 @@ def test_download_index(self):
self.assertContains(response, "Browse Python 3.6.0 Documentation")
self.assertContains(response, "https://docs.python.org/3/whatsnew/3.6.html")
self.assertContains(response, "What's new in Python 3.6")

def test_docs_versions_ignores_malformed_release_version(self):
Release.objects.create(
name="Python 4",
is_published=True,
pre_release=False,
)

response = self.client.get(reverse("docs-versions"))
self.assertEqual(response.status_code, 200)
2 changes: 2 additions & 0 deletions pydotorg/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ def get_context_data(self, **kwargs):

# Get major.minor version ("3.14.0" -> "3.14")
version_parts = full_version.split(".")
if len(version_parts) < SEMANTIC_VERSION_PARTS - 1:
continue
major_minor = f"{version_parts[0]}.{version_parts[1]}"

# For 3.2.0 and earlier, use X.Y instead of X.Y.0
Expand Down