Skip to content

Comments

Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929

Open
iampujan wants to merge 1 commit intopython:mainfrom
iampujan:feature/issue-2611-deprecate-provided-assets-view
Open

Fix #2611: Deprecate ProvidedSponsorshipAssetsView#2929
iampujan wants to merge 1 commit intopython:mainfrom
iampujan:feature/issue-2611-deprecate-provided-assets-view

Conversation

@iampujan
Copy link
Contributor

Deprecates ProvidedSponsorshipAssetsView as its functionality is now wholly covered by SponsorshipDetailView. The old template and url have been removed.

Copilot AI review requested due to automatic review settings February 21, 2026 10:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates and removes the legacy ProvidedSponsorshipAssetsView endpoint/template now that “provided assets” are surfaced directly within SponsorshipDetailView (sponsorship_detail.html).

Changes:

  • Removed ProvidedSponsorshipAssetsView and its URL route.
  • Deleted the legacy sponsorship_assets_view.html template and removed the “View all assets” link from the sponsorship detail page.
  • Updated provided-asset user_view_url to point to the sponsorship detail page’s “Provided Assets” section.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
apps/users/views.py Removes the deprecated ProvidedSponsorshipAssetsView.
apps/users/urls.py Removes the provided-assets/ route.
apps/users/templates/users/sponsorship_detail.html Removes the link to the deleted provided-assets page.
apps/users/templates/users/sponsorship_assets_view.html Deletes the deprecated template.
apps/sponsors/models/benefits.py Updates user_view_url to deep-link to the provided-assets section on the sponsorship detail page.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -314,8 +314,8 @@ def user_edit_url(self):
@property
def user_view_url(self):
"""Return the URL for sponsors to view this provided asset."""
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user_view_url’s docstring says it returns a URL to view this provided asset, but the implementation now links to the sponsorship detail page’s provided-assets section and no longer encodes which asset is being referenced. Either update the docstring (and/or property name) to reflect the new behavior, or add a per-asset deep link (e.g., an element id per asset) so the URL can still target a specific asset.

Suggested change
"""Return the URL for sponsors to view this provided asset."""
"""Return the URL for sponsors to view the sponsorship's provided assets section."""

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant