gh-145037: Fix Emscripten trampoline with emcc >= 4.0.19#145038
Open
hoodmane wants to merge 1 commit intopython:mainfrom
Open
gh-145037: Fix Emscripten trampoline with emcc >= 4.0.19#145038hoodmane wants to merge 1 commit intopython:mainfrom
hoodmane wants to merge 1 commit intopython:mainfrom
Conversation
hoodmane
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
hoodmane
force-pushed
the
emscripten-trampoline-pointer
branch
from
0725f55 to
200d8fe
Compare
This undoes a change made as a part of PR 137470. We add an `emscripten_trampoline` field in `pycore_runtime_structs.h` and initialize it from JS initialization code with the wasm-gc based trampoline if possible. Otherwise we fall back to the JS trampoline.
hoodmane
force-pushed
the
emscripten-trampoline-pointer
branch
from
200d8fe to
526e102
Compare
hoodmane
added
OS-emscripten
interpreter-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This undoes a change made as a part of #137470. We add an
emscripten_trampolinefield inpycore_runtime_structs.hand initialize it from JS initialization code with the wasm-gc based trampoline if possible. Otherwise we fall back to the JS trampoline.cc @freakboy3742 @ryanking13