GH-145006: add ModuleNotFoundError hints when a module for a differen…#145007
Open
FFY00 wants to merge 1 commit intopython:mainfrom
Open
GH-145006: add ModuleNotFoundError hints when a module for a differen…#145007FFY00 wants to merge 1 commit intopython:mainfrom
FFY00 wants to merge 1 commit intopython:mainfrom
Conversation
…fferent ABI exists Signed-off-by: Filipe Laíns <lains@riseup.net>
Contributor
|
Unforetunately, multiple checks seem to be failing, I'll have a look on this |
| import collections.abc | ||
| import itertools | ||
| import linecache | ||
| import os |
Contributor
There was a problem hiding this comment.
Suggested change
| import os | |
| import os | |
| from pathlib import Path |
| traversable = importlib.resources.files(parent) | ||
| else: | ||
| traversable = importlib.resources.readers.MultiplexedPath( | ||
| *filter(os.path.isdir, sys.path) |
Contributor
There was a problem hiding this comment.
Suggested change
| *filter(os.path.isdir, sys.path) | |
| *[Path(p) for p in sys.path if os.path.isdir(p)] |
Contributor
benediktjohannes
left a comment
benediktjohannes
left a comment
There was a problem hiding this comment.
I guess that this should fix the failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModuleNotFoundErrorhints when a module for a different ABI exists #145006