Add warning for building detection in publish job#373
Draft
Copilot wants to merge 2 commits intounstable/v1from
Draft
Add warning for building detection in publish job#373Copilot wants to merge 2 commits intounstable/v1from
Copilot wants to merge 2 commits intounstable/v1from
Conversation
Author
|
@webknjaz 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: webknjaz <578543+webknjaz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Show a warning in workflow runs suspect of building in the publish job
Add warning for building detection in publish job
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a security-focused warning that detects when building appears to be happening in the same job as publishing, which is not a supported pattern and can introduce security risks.
What it does
The implementation adds detection logic to
twine-upload.shthat checks for indicators that building is occurring in the publish job:.git/directory (indicatesactions/checkoutwas used)pyproject.toml,setup.py,setup.cfg,Cargo.tomlsrc/,lib/build/,.tox/,venv/,.venv/requirements.txt,requirements.inWhen any of these indicators are detected, the action displays a warning message explaining the security risks and directing users to follow the supported pattern of building in a separate job and downloading artifacts in the publish job.
Why this matters
This aligns with the existing guidance in the README that this action "has nothing to do with building package distributions" and that users should build in separate jobs with restricted privileges. The warning helps enforce this security best practice by making it prominent when users deviate from the supported pattern.
Example warning output
The detection logic is conservative and only warns when clear indicators of building are present. Clean publish jobs that only contain the packages directory (e.g., after downloading artifacts) will not trigger the warning.
Fixes #324.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.