Closed
Conversation
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
826d2cd to
5adef7f
Compare
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
5adef7f to
4f9ed98
Compare
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
4fa5d39 to
1cd6d8c
Compare
The ref is very long and makes things unreadable.
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
1cd6d8c to
33a1b50
Compare
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
0ffcff5 to
3ed52b0
Compare
iluuu1994
force-pushed
the
ci-combine-push-and-root
branch
from
3ed52b0 to
33a5586
Compare
Member
Author
TimWolla
reviewed
Feb 18, 2026
| # When running nightly, set fetch-depth to 0 to clone the full | ||
| # repository including all branches. This is required to find the | ||
| # correct commit hashes. | ||
| fetch-depth: ${{ (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && 0 || 1 }} |
Member
There was a problem hiding this comment.
I think this might not work correctly, because 0 is falsy in JavaScript, which I believe backs the expression syntax.
&& "0" || "1" should do the trick.
Possibly it also makes sense to add an extra step setting a “helper” variable, for readability:
- name: Check nightly
id: is-nightly
run: |
if [ "${{ github.event_name }}" = "schedule" ] || [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
echo "nightly=1" >> $GITHUB_OUTPUT
else
echo "nightly=0" >> $GITHUB_OUTPUT
fi
And then use ${{ steps.is-nightly.outputs.nightly }} in conditions instead of repeating them.
Member
Author
There was a problem hiding this comment.
Very good catch. I fixed this in the first way you suggested for now. And I also remembered that "" needs to be '' after I already pushed the fix. ^^
TimWolla
reviewed
Feb 18, 2026
| id: set-matrix | ||
| run: php .github/nightly_matrix.php "${{ github.event_name }}" "${{ github.run_attempt }}" "${{ github.ref }}" '${{ toJSON(github.event.pull_request.labels) }}' "${{ github.repository }}" | ||
| run: php .github/matrix.php "${{ github.event_name }}" "${{ github.run_attempt }}" "${{ github.ref }}" '${{ toJSON(github.event.pull_request.labels) }}' "${{ github.repository }}" | ||
| PUSH: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.