Fix unsound SCCP for partial objects with hooks#21233
Open
iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
Open
Fix unsound SCCP for partial objects with hooks#21233iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
Conversation
arnaud-lb
reviewed
Feb 17, 2026
Member
arnaud-lb
left a comment
There was a problem hiding this comment.
I was wondering if __set would cause unsoundness as well, but it doesn't. Looks like that objects with __set are considered escaped in zend_ssa_escape_analysis(), and as a result we skip this optimization. Should we do the same for hooks?
Comment on lines
+992
to
+994
| // FIXME: With dynamic property warnings and hooks this has | ||
| // become decreasingly useful. Maybe partial objects should just | ||
| // be removed. |
Member
There was a problem hiding this comment.
I would expect the optimization to be useful, especially if we can enable it on typed props, when the value assigns cleanly.
Member
|
A similar issue happens with typed references: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-21231