Skip to content

Comments

feat: added a guide for the passkey integrations#2362

Merged
deepakprabhakara merged 15 commits intomasterfrom
jhickmanit/passkeys-guide
Feb 21, 2026
Merged

feat: added a guide for the passkey integrations#2362
deepakprabhakara merged 15 commits intomasterfrom
jhickmanit/passkeys-guide

Conversation

@jhickmanit
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

…le passkeys. Also tackled a bit of the web passkeys as well.
Co-authored-by: Jonas Hungershausen <jonas.hungershausen@ory.sh>
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Nov 26, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm,
a few style issues and sidebar is missing.
let me know if I can help with sidebar, im quite familiar with it.

only nit is that I would prefer the troubleshooting part to be a separate doc under https://www.ory.com/docs/category/troubleshooting and that the doc is maybe a bit overly verbose, but that is more a personal preference ;)

Co-authored-by: Vincent <vincent@ory.sh>
@jhickmanit
Copy link
Contributor Author

If you could help with the sidebar and feel free to split the troubleshooting to a different document for sure!

…ssetlink.json to be explicit about RP ID being the recommended host for these files.
vinckr
vinckr previously requested changes Dec 8, 2025
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a redirect bc 06_code.mdx has been renamed to 07_code.mdx

@vinckr vinckr dismissed their stale review December 8, 2025 15:39

actually doesn't need redirect

@deepakprabhakara deepakprabhakara merged commit 96720b0 into master Feb 21, 2026
10 checks passed
@deepakprabhakara deepakprabhakara deleted the jhickmanit/passkeys-guide branch February 21, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream Issue is caused by an upstream dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants