fix list-qt-official wrt types, search term.#990
Open
tsteven4 wants to merge 1 commit intomiurahr:masterfrom
Open
fix list-qt-official wrt types, search term.#990tsteven4 wants to merge 1 commit intomiurahr:masterfrom
tsteven4 wants to merge 1 commit intomiurahr:masterfrom
Conversation
only one search term is used by the official installer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we accepted zero, one or more search terms for list-qt-official. However, the official installer ignores all terms after the first. This PR changes argument parsing for list-qt-official so only zero or one search terms are accepted.
This PR also fixes the mypy errors in installer.py:
The second was fixed by eliminating variable reuse of version_str by renaming, allowing different type signatures to be inferred by mypy for the different usages.
This resolves #965.