Fix from and with method types of Temporal.PlainMonthDay#63142
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Feb 17, 2026
Merged
Fix from and with method types of Temporal.PlainMonthDay#63142jakebailey merged 1 commit intomicrosoft:mainfrom
from and with method types of Temporal.PlainMonthDay#63142jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
Author
|
@microsoft-github-policy-service agree |
jakebailey
reviewed
Feb 15, 2026
fabon-f
force-pushed
the
fix-temporal-pmd
branch
from
cbd261e to
701246b
Compare
fabon-f
changed the title
Temporal.MonthDayLikeObject typefrom and with method types of Temporal.PlainMonthDay
justingrant
reviewed
Feb 17, 2026
| nanoseconds?: number | undefined; | ||
| } | ||
|
|
||
| interface MonthDayLikeObject extends Omit<DateLikeObject, "era" | "eraYear"> {} |
Contributor
There was a problem hiding this comment.
I actually think it'd be good to leave this type and just assign it to DateLikeObject. Then, if a future TS manages to describe the complexity of Temporal's types then existing users who've imported MonthDayLikeObject will automatically pick up the more accurate rules.
Member
There was a problem hiding this comment.
Is that possible without a break? This is an interface type, so at most we can add more properties to it.
Contributor
There was a problem hiding this comment.
Ahh, good point. In that case, then this change is fine.
| readonly monthCode: string; | ||
| readonly day: number; | ||
| with(monthDayLike: PartialTemporalLike<MonthDayLikeObject>, options?: OverflowOptions): PlainMonthDay; | ||
| with(monthDayLike: PartialTemporalLike<DateLikeObject>, options?: OverflowOptions): PlainMonthDay; |
jakebailey
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60164, follow-up PR of #62628 (based on #62628 (comment)).
Temporal.PlainMonthDay.from(andTemporal.PlainMonthDay.prototype.with) accepts a pair oferaanderaYearas well asyear.