Skip to content

Comments

docs: update to align with current implementation#1823

Open
robekl wants to merge 1 commit intomeshcore-dev:mainfrom
robekl:docs_update_main
Open

docs: update to align with current implementation#1823
robekl wants to merge 1 commit intomeshcore-dev:mainfrom
robekl:docs_update_main

Conversation

@robekl
Copy link

@robekl robekl commented Feb 24, 2026

Summary

Documentation-only PR to align main docs with current dev behavior and protocol details.

High-Level Changes by Category

Companion Behavior & Routing

  • Updated docs to reflect that companion nodes do not repeat by default.
  • Added/clarified optional companion client repeat mode and its constraints.

CLI Documentation

  • Added missing commands and corrected command details/defaults.
  • Fixed outdated command descriptions and minor terminology issues.

Companion Protocol

  • Updated protocol version references.
  • Corrected frame formats, field sizes, packet meanings, and units.
  • Added missing details for repeat-mode-related protocol fields.

Payload & Packet Specs

  • Corrected payload field semantics and tag/ack descriptions.
  • Replaced stale version-specific wording with current implementation behavior.
  • Filled incomplete payload sections with implementation-aligned definitions.

FAQ Accuracy

  • Updated answers that were out of date with current implementation.
  • Corrected OTA/WiFi setup references and minor wording/grammar issues.

Copy link
Member

@liamcottle liamcottle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the couple of comments I added, everything else looks pretty good thanks :)

- `path` - size provided by `path_length` - Path to use for Direct Routing
- Up to a maximum of 64 bytes, defined by `MAX_PATH_SIZE`
- v1.12.0 firmware and older drops packets with `path_length` [larger than 64](https://github.com/meshcore-dev/MeshCore/blob/e812632235274ffd2382adf5354168aec765d416/src/Dispatcher.cpp#L144)
- Current firmware drops packets with `path_length` larger than 64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be accurate when multi-byte-paths branch is merged in, hence it was worded to say v1.12.0 firmware and older. v1.14.0+ firmware would allow packets with path_length > 64, as it uses those upper bits for new path info flags. I'd probably suggest reverting this line, and when the branch is merged we can add an extra line explaining the new functionality.

- Generally this is the remainder of the raw packet data
- The firmware parses this data based on the provided Payload Type
- v1.12.0 firmware and older drops packets with `payload` sizes [larger than 184](https://github.com/meshcore-dev/MeshCore/blob/e812632235274ffd2382adf5354168aec765d416/src/Dispatcher.cpp#L152)
- Current firmware drops packets with `payload` sizes larger than 184
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about multi-byte-paths above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants