fix(commoncli): prevent command prefix overreads in handleCommand#1819
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(commoncli): prevent command prefix overreads in handleCommand#1819robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Replace fixed-length memcmp prefix checks with a bounded helper that first verifies the input has at least the required prefix length. This preserves existing command matching behavior while avoiding out-of-bounds reads on short command strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unsafe command-prefix parsing in
CommonCLI::handleCommandthat could read past the end of short input buffers.Bug
handleCommandused fixed-lengthmemcmpchecks against command literals.If the incoming command string was shorter than the compared length, the comparison could read beyond valid memory.
Trigger
Send a short or truncated CLI command that reaches a longer prefix check path (for example partial command tokens).
Impact
Fix
Replaced unsafe fixed-length
memcmpusage with bounded prefix matching (prefixEq) that validates string length before comparing.