fix(utils): reject invalid hex characters in fromHex#1818
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(utils): reject invalid hex characters in fromHex#1818robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Make hexVal return -1 for invalid input and validate each nibble in Utils::fromHex before decoding. Also simplify isHexChar to rely on the same validation path, preventing invalid strings from being accepted as zero bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
Utils::fromHexto reject non-hex characters instead of silently converting them.Bug
Hex conversion treated invalid characters as zero-equivalent values in decode flow, allowing malformed input to pass as valid bytes.
Trigger
Provide non-hex input to flows that decode hex strings (example pattern:
"zz"in a command expecting hex payload/ID).Impact
Fix
Introduced strict nibble validation (
hexValreturns invalid for non-hex chars) and madefromHexfail-fast on invalid characters.