fix(advert): validate parser input lengths before decoding fields#1816
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
fix(advert): validate parser input lengths before decoding fields#1816robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
Guard AdvertDataParser against truncated payloads and null/empty buffers before reading optional lat/lon and feature sections. Also cap copied name length to leave room for null termination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents buffer overreads in advertisement decoding by validating packet length before optional field reads.
Bug
Advert parsing logic could read optional fields without confirming sufficient remaining bytes, especially for truncated payloads.
Trigger
Feed truncated or malformed advertisement payloads where declared/expected fields are incomplete.
Impact
Fix
Added defensive input-length checks before each optional read and capped name-copy length to available buffer capacity.