docs: correct stats binary frame lengths and subtype error handling#1814
Open
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Open
docs: correct stats binary frame lengths and subtype error handling#1814robekl wants to merge 1 commit intomeshcore-dev:devfrom
robekl wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Targeted fixes in
docs/stats_binary_frames.mdto match currentCMD_GET_STATSbinary framing.Changes
STATS_TYPE_PACKETSframe size to 30 bytes in current firmware.recv_errorsas present in current packet-stats response payload.RESP_CODE_ERR+ERR_CODE_ILLEGAL_ARG.Implementation References
examples/companion_radio/MyMesh.cppCMD_GET_STATS,STATS_TYPE_CORE,STATS_TYPE_RADIO,STATS_TYPE_PACKETSRESP_CODE_STATSMyMesh::handleCmdFramestats branchMyMesh::writeErrFramefor invalid subtype path