Respect saved buzzer preference during startup#1803
Open
andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
Open
Respect saved buzzer preference during startup#1803andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
andrewdefilippis wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
buzzer.begin() unconditionally enabled the buzzer and played the startup sound before the saved preference was applied. Users who disabled the buzzer via triple-press would still hear the startup beep on every boot. Move startup sound out of begin() and into UITask where the saved preference is already available. begin() now only initializes hardware in a quiet state. The caller applies the preference, then conditionally plays the startup sound. Tested on T1000-E hardware — startup sound correctly plays only when the buzzer is enabled, and is silent when previously disabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andrewdefilippis
added a commit
to andrewdefilippis/MeshCore
that referenced
this pull request
Feb 23, 2026
Document devcontainer build workarounds (toolchain pin, GCC 14 narrowing fix) in CLAUDE.md so they are discoverable on the workspace branch. Add research and plan docs for the buzzer startup preference fix (PR meshcore-dev#1803).
Contributor
|
Hi! I am the developer of #1543. I'd be happy to coordinate, improving buzzer controls is a very high priority of mine, and seemingly for some other users who wish to get more functionality out of devices like the T1000-E and WisMesh Tag. If you need anything from me, please do not hesitate to @ me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables startup sound when buzzer silenced on T1000-E and WisMesh Tag.