MLE-27078 More tests for this bug

[rjrudin]

Made a very confusing private field easier to understand in DocumentManagerImpl.

[github-actions]

Copyright Validation Results
Total: 5 | Passed: 2 | Failed: 0 | Skipped: 3 | at: 2026-02-18 18:46:27 UTC | commit: 31e1744

⏭️ Skipped (Excluded) Files

• .env
• Jenkinsfile
• test-app/build.gradle

✅ Valid Files

• marklogic-client-api/src/main/java/com/marklogic/client/impl/DocumentManagerImpl.java
• marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadJsonAsBinaryTest.java

✅ All files have valid copyright headers!

[Copilot]

Pull request overview

This pull request fixes a bug (MLE-27078) in DocumentManagerImpl where a class field was being used to track whether metadata categories were modified, leading to incorrect behavior. The fix replaces the stateful tracking with a simple method that determines if the metadata categories differ from the default (ALL).

Changes:

• Removed the stateful isProcessedMetadataModified boolean field and the overridden add/addAll methods in the processedMetadata HashSet
• Introduced a new private method isMetadataCategoriesNotJustAll() to check if metadata categories have been modified from the default
• Added comprehensive test coverage demonstrating the fix allows bulk reads after setting metadata to ALL

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
ReadJsonAsBinaryTest.java	Adds new test methods to verify bulk read behavior with different metadata category configurations, including the case where setting to ALL should work correctly
DocumentManagerImpl.java	Removes problematic stateful tracking and replaces it with a cleaner method-based approach; updates all references from processedMetadata to metadataCategories

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The null check for metadataCategories is redundant. The field is instantiated as a new HashSet on line 58 and can never be null. The check should be removed or replaced with a check for an empty set if that's the intended behavior.

[Copilot]

Inconsistent indentation: this file uses 2-space indentation throughout (see lines 44-45, 49-50, 74-77, 617-623), but tabs are used here. Replace tabs with 2 spaces to maintain consistency.

[Copilot]

Inconsistent indentation: this file uses 2-space indentation throughout (see lines 44-45, 49-50, 74-77, 617-623), but tabs are used here. Replace tabs with 2 spaces to maintain consistency.