Add benchmarks and optimize Hashing util#3
Merged
KSemenenko merged 2 commits intomanagedcode:mainfrom Dec 2, 2025
Merged
Conversation
…ptimized and current implementations
Member
|
Thanks a lot! This is just an amazing PR! |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added benchmarks to cover some parts of the system. The intention is to have perf benchmarks & test coverage so that code optimizations can be properly applied and regressions (if any) captured.
Related Issues
N/A
Proposed Changes
GenerateSha512HashmethodTested to ensure optimized version generates same hash as existing one. Ran current/optimized version side by side. Pasting BenchmarkDotNet results below
As can be seen memory allocations are capped at 440 B regardless of the fields' payload. However, this comes with a trade off of perf regression for medium & large properties. For small & large values performance actually improves. However, suggested changes are mainly to improve allocations.
Checklist
Additional Notes
N/A