Update to allow sourcing docker images from internal registry#129
Open
Update to allow sourcing docker images from internal registry#129
Conversation
…, by adding prefix to image name - leverages existing DOCKER_GLOBAL_IMAGE_PREFIX config
…o allow usage when latest tag is blocked
plafond
changed the title
…tate - also updated minor version trying to ensure changes get applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverages existing DOCKER_GLOBAL_IMAGE_PREFIX config, if present, by adding prefix to image name.
Customer request created for wiremock extension but this changes is to common util and should apply to ALL extensions...
** also looking ahead, adding ability to wiremock extension to specify image name (including tag) to allow usage when latest tag is blocked
wiremock/wiremock:4x-beta images seems to have issues (getting a connection refused) - specifying :latest is working fine
not sure if minor bump on the extension-utils package is actually needed?