Add global fallback for failed symbol lookups#141
Draft
Conversation
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
kwerle
reviewed
Feb 25, 2026
| all_scopes = all_scopes.where(class_method: class_method_filter) unless class_method_filter.nil? | ||
| results.concat(all_scopes.to_a) | ||
|
|
||
| # Also search for constants/variables globally |
Owner
There was a problem hiding this comment.
No - let's not look for variables.
Contributor
Author
There was a problem hiding this comment.
Removed variable search from the fallback. The fallback now only searches for scopes (classes, modules, methods). Commit: 7bc7dac
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add fallback functionality for lookup failures
Add global fallback for failed symbol lookups
Feb 25, 2026
kwerle
requested changes
Feb 25, 2026
Owner
kwerle
left a comment
There was a problem hiding this comment.
In the fallback do not look for variables
Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Contributor
Author
Done. The fallback now only searches for scopes and not variables. Also removed the related test. Commit: 7bc7dac |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When go-to-definition fails to find a symbol in the current scope chain, it now falls back to a project-wide search. Previously returned empty results for symbols defined elsewhere.
Changes
lib/ruby_language_server/project_manager.rb: Added global search fallback inproject_definitions_forafter scope chain exhaustionTests: Added coverage for cross-file/cross-scope lookups of classes and methods
Example
Before: Failed to find
StringUtils(not inServicesscope chain)After: Finds definition via global fallback
Note: The fallback searches for scopes (classes, modules, methods) only. Variables/constants are not included in the global fallback to avoid performance issues and maintain locality of variable references.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.