Skip to content

Comments

Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent#2622

Open
joliver82 wants to merge 3 commits intojMonkeyEngine:masterfrom
joliver82:fix-noise-on-android
Open

Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent#2622
joliver82 wants to merge 3 commits intojMonkeyEngine:masterfrom
joliver82:fix-noise-on-android

Conversation

@joliver82
Copy link
Contributor

@joliver82 joliver82 commented Feb 21, 2026

A quick PR to fix noiselib on android (and possibly other GLES systems). When using literals it's required to add decimals when type of the function called is float, otherwise depending on the device we may get errors when compiling the shader:

S0001: No matching overload for function 'Noise3D' found

Improved GLSLCompat to avoid issues in legacy GLES devices (GLSL<130) not having sampler2DArray type

@github-actions
Copy link

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

Copy link
Member

@riccardobl riccardobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants