Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent#2622
Fix noiselib to properly compile on android (float literals). Also fixed NoiseLib.glsllib code indent#2622joliver82 wants to merge 3 commits intojMonkeyEngine:masterfrom
Conversation
Also fixed code indent
…ing sampler2DArray
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
A quick PR to fix noiselib on android (and possibly other GLES systems). When using literals it's required to add decimals when type of the function called is float, otherwise depending on the device we may get errors when compiling the shader:
S0001: No matching overload for function 'Noise3D' found
Improved GLSLCompat to avoid issues in legacy GLES devices (GLSL<130) not having sampler2DArray type