Refactor hyperlight_component_util to use tracing crate#1234
Open
vshailesh wants to merge 2 commits intohyperlight-dev:mainfrom
Open
Refactor hyperlight_component_util to use tracing crate#1234vshailesh wants to merge 2 commits intohyperlight-dev:mainfrom
vshailesh wants to merge 2 commits intohyperlight-dev:mainfrom
Conversation
vshailesh
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
ludfjig
added
the
kind/refactor
vshailesh
changed the title
Contributor
Author
|
miri test failed here, does it not produce any logs? is there a way to know what is causing this failure? |
Member
|
I didn't have a chance to review the change or the motivation for it yet. Just commenting on the CI issue.
It looks like the CI runner died. I triggered a re-run. |
dblnz
reviewed
Feb 16, 2026
| itertools = { version = "0.14.0" } | ||
| prettyplease = { version = "0.2.37" } | ||
| log = { version = "0.4" } No newline at end of file | ||
| log = { version = "0.4" } |
Contributor
Author
There was a problem hiding this comment.
no, we can actually remove it. I will do that
vshailesh
force-pushed
the
tracing-refactor2
branch
2 times, most recently
from
16294b8 to
c7b0c7b
Compare
Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>
vshailesh
force-pushed
the
tracing-refactor2
branch
from
c7b0c7b to
60bcdfc
Compare
Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracingcrate instead oflogto create logs #1028