Skip to content

Comments

fix: update workflows to respect matrix node version#7293

Open
pearigee wants to merge 5 commits intomainfrom
pearigee-node-version-fix
Open

fix: update workflows to respect matrix node version#7293
pearigee wants to merge 5 commits intomainfrom
pearigee-node-version-fix

Conversation

@pearigee
Copy link
Contributor

@pearigee pearigee commented Feb 23, 2026

Our workflows are miss configured and as a result are not respecting the node version specified by matrix.

To fix this I have made the following changes:

  1. I added a workflow step to explicitly initialize our Node.js environment (using actions/setup-node) that explicitly sets the requested node version from the matrix arguments. This step also configures other helpful items like dependency caching, which may help us performance wise? More testing on this is required.
  2. I bumped our pnpm version to 10 to get the latest security and performance fixes. It looks like 10 may be the last version to officially support node 18.

Before fix:
image

After fix:
image

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #7289 🦕

@pearigee pearigee requested a review from a team as a code owner February 23, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests are not running with correct node version (i.e. 18 is running on 22)

2 participants