Update test expectations after switch to SoftFloat library in the extractor#1042
Open
jketema wants to merge 1 commit intogithub:nextfrom
Open
Update test expectations after switch to SoftFloat library in the extractor#1042jketema wants to merge 1 commit intogithub:nextfrom
jketema wants to merge 1 commit intogithub:nextfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates C++ AUTOSAR rule unit test expected outputs to align with the extractor’s new SoftFloat-based floating-point formatting, preventing test failures due to numeric rendering differences.
Changes:
- Adjust floating-point literal renderings in
.expectedfiles (e.g., normalized scientific notation / exponent casing). - Update expected-result row numbering where output ordering/formatting shifted.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/autosar/test/rules/M5-0-6/ImplicitConstConversionToSmallerUnderlyingType.expected | Updates expected float conversion output formatting for SoftFloat extractor output. |
| cpp/autosar/test/rules/M2-13-4/LiteralSuffixNotUpperCase.expected | Updates expected floating-point literal value formatting for suffix diagnostics. |
| cpp/autosar/test/rules/A13-6-1/UseCorrectIntervalForDigitSequencesSeparators.expected | Updates expected floating-point digit-separator diagnostics value formatting to match SoftFloat output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.