Skip to content

Make site mobile responsive #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritorhymes wants to merge 7 commits into
base: main
Choose a base branch
from
+32 −18
Open

Make site mobile responsive #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61c0f44
add viewport tag for standard mobile scaling
ritorhymes Feb 6, 2026
dda45b2
replace header table layout with responsive image
ritorhymes Feb 6, 2026
dad29bc
add code block bg and horizontal scroll to prevent broken page scroll…
ritorhymes Feb 6, 2026
09b532d
allow text to wrap down to prevent broken horizontal page scrolling o…
ritorhymes Feb 6, 2026
494ec51
reduce margin spacing on mobile to let content scale
ritorhymes Feb 6, 2026
893130a
scale down banner title to fit on smaller screens
ritorhymes Feb 6, 2026
38776e1
contain graphviz SVG size on mobile to prevent broken horizontal page…
ritorhymes Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions assets/sass/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ body {
background-image: linear-gradient(#d7cdc0ff, #fdf7f6ff);
margin-right: 10%;
margin-left: 10%;
overflow-wrap: break-word;
Copy link
Member

@dscho dscho Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a fixup for dad29bc that would want to be squashed into that commit instead of living on its own? Also, the commit message does not help me understand the problem, the context, and why the proposed solution is the best way to solve the problem. I would love it to help me, though.

}
.block {
background-color: rgb(247, 243, 239);
Expand All @@ -13,19 +14,36 @@ body {
padding-bottom: .1em;
border-radius: 2em;
}
img {
max-width: 100%;
height: auto;
}
.banner {
text-align: center;
font-weight: bold;
td img {
height: 150px;
}
}
big {
font-size: 400%;
}
small {
font-size: 70%;
}
pre {
background-color: rgb(247, 243, 239);
border: 1px solid #c5bbb0;
border-radius: 0.5em;
padding: 1em;
overflow-x: auto;
}
code {
background-color: rgb(247, 243, 239);
padding: 0.1em 0.3em;
border-radius: 0.25em;
}
pre code {
background-color: transparent;
padding: 0;
}
Comment on lines +30 to +45
Copy link
Member

@dscho dscho Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to learn from this. To that end, would you mind extending the commit message quite a bit? I'd like it more in line with https://github.blog/2022-06-30-write-better-commits-build-better-projects/, in particular with a strong focus on this part:

  What you’re doing Why you’re doing it
High-level (strategic) Intent (what does this accomplish?) Context (why does the code do what it does now?)
Low-level (tactical) Implementation (what did you do to accomplish your goal?) Justification (why is this change being made?)

div.feature-matrix {
table {
border-collapse: collapse;
Expand Down Expand Up @@ -60,7 +78,16 @@ div.feature-matrix {
vertical-align: center;
}
}
@media screen and (max-width: 450px) {
big {
font-size: 300%;
}
}
@media screen and (max-width: 767px) {
body {
margin-right: 3%;
margin-left: 3%;
}
.tg {
width: auto !important;
}
Expand Down
2 changes: 2 additions & 0 deletions layouts/_default/baseof.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>{{ .Title }}</title>
{{- $style := resources.Get "sass/main.scss" | resources.ExecuteAsTemplate "main.scss" . | css.Sass }}
<link rel="stylesheet" href="{{ $style.RelPermalink }}">
Expand Down
15 changes: 0 additions & 15 deletions layouts/partials/banner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,6 @@
<small>... one iteration at a time... </small>
{{- end -}}
<div class="banner">
{{- if eq .Kind "home" }}
Copy link
Member

@dscho dscho Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that this is the reason for this regression:

BeforeAfter
Image Image

Hopefully this is easy to fix...

{{ partial "logo.html" . }}
{{ partial "subtitle.html" . }}
{{- else }}
<table style="width: 100%">
<tbody>
<tr>
<td>
{{ partial "logo.html" . }}
</td>
<td>
{{ partial "subtitle.html" . }}
</td>
</tr>
</tbody>
</table>
{{- end }}
</div>{{ if eq .Kind "home" }}<hr />{{ end }}