Draft
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the SDK's TypeScript version from
~5.8.0to^6.0.0-beta. TypeScript 6 surfaces all the deprecations that will become hard errors in TypeScript 7 (the Go-compiled rewrite), so fixing them now gives us a smooth migration path when v7 ships.You can check the official migration guide that I followed here.
Changes
base tsconfig (
packages/typescript/tsconfig.json)alwaysStrict,downlevelIteration"DOM"toliband"node"totypesrootDiracross all packagesrootDirto every tsconfig that hasoutDir. TS 6 requires this to be set explicitly"./src", dev-packages with source outsidesrc/use"."baseDirdeprecationbaseDir is deprecated, but it doesn't affect us much. The only affected package is
emberand was fixed by converting the paths to relative paths.Several Type Fixes
BodyInit.@ts-expect-errorare no longer necessary.Set
moduleResolutiontobundlerSince
nodehas been deprecated, we needed to switch to another resolution strategy that fits what we do here. The best value that fits isbundlerbut it means we can't import from src like we did.So I updated some packages to export the types that other packages need, which is nice because it means we no longer depend on the output folder structure of the packages, but rather what the modules export.
Angular compatibility
tsconfig.ngc.json(removingextendschain) becauseng-packagrships its own older TypeScript that rejects"moduleResolution": "bundler"when parsing the base config