Add regression test for #226 (snapshot-ui CLI crash)#228
Open
TomMcGrath7 wants to merge 2 commits intogetsentry:mainfrom
Open
Add regression test for #226 (snapshot-ui CLI crash)#228TomMcGrath7 wants to merge 2 commits intogetsentry:mainfrom
TomMcGrath7 wants to merge 2 commits intogetsentry:mainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
The root cause (wrong tool names in
snapshot_ui.ts+ missing fallback innext-steps-renderer.ts) is already fixed in main but was present in thev2.0.7 npm release. This adds a regression test to prevent it from
reoccurring.
The test simulates the exact v2.0.7 scenario:
tap_coordinateandtake_screenshottool names with nocliToolmapping, and verifiesrenderNextStepsSectionhandles it gracefully.Found same bug while testing on simulators.