Conversation
There was a problem hiding this comment.
Code Review
This pull request reorganizes documentation and assets by moving them to more appropriate directories. While the structure is improved, moving docs/DESIGN.md to specs/design.md breaks the relative image links on lines 24 and 28; these should be updated to ../assets/ to point to the new root-level assets folder. Additionally, the repository style guide expects a specs/README.md file, so renaming specs/design.md accordingly would ensure compliance. Finally, there is a versioning inconsistency in the title of docs/migration/migration_0.7.0_to_0.9.0.md, which incorrectly references version 0.8.0 in its main header.
|
I think the assets folder should stay within The I actually question that the specs folder should be called that, since the things in it aren't specifications, really. It seems more like information for contributors. |
Yes! Let's find structure that we both like. I would like to see clear separation:
We also have This is another option to structure the docs:
Thoughts? |
Yes, let's put it all under docs. That sounds like a good organization. |
|
Thanks, applied. |
|
Can we move specs into the docs folder too? Then all the docs will be in one place. |
|
/gemini review Verify links to assets are not broken and all assets are used. |
There was a problem hiding this comment.
Code Review
The pull request improves documentation organization by renaming and moving several documentation files into more logical directories, and by removing outdated launch configurations. The changes enhance clarity and maintainability of the project's documentation structure. The removal of the extra blank line in run_app_with_gemini_key.md is a good cleanup. The changes to README.md to reflect the new documentation path are also appropriate.
I am having trouble creating individual review comments. Click here to see my feedback.
.vscode/launch.json (31-47)
These launch configurations for custom_backend and tic_tac_toe (dartantic) have been removed. If these examples are no longer relevant or maintained, their removal is appropriate for cleaning up the development environment. However, if these are still valid examples that should be runnable, they should be updated to reflect the current project structure or kept if they are still functional.
|
/gemini
Can you verify the examples do not exist any more? |
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
No description provided.