feat(go): added common middleware (e.g. tool approval, retry, fallback)#4719
feat(go): added common middleware (e.g. tool approval, retry, fallback)#4719apascal07 wants to merge 3 commits intoap/go-middlewarefrom
Conversation
github-actions
bot
added
docs
Summary of ChangesHello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the extensibility and control over AI generation flows by introducing a new, unified middleware system. This system allows developers to inject custom logic at various stages of the generation process, including before generation, around model calls, and during tool execution. The changes include new type definitions, schema updates, and the implementation of several practical middleware plugins, providing robust capabilities for handling errors, retries, fallbacks, and tool interactions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive middleware system for Go, adding valuable features like retry, fallback, and tool approval. The implementation is well-structured, with each middleware in its own file accompanied by thorough tests. Key improvements include replacing the generic JSON-based clone function with more efficient and type-safe Clone methods, and a new context-based mechanism for middleware to access the Genkit registry. The overall changes significantly enhance the framework's flexibility and robustness. I have a couple of minor suggestions for improving code clarity and hygiene.
|
|
||
| // GenerateWithRequest is the central generation implementation for ai.Generate(), prompt.Execute(), and the GenerateAction direct call. | ||
| func GenerateWithRequest(ctx context.Context, r api.Registry, opts *GenerateActionOptions, mw []ModelMiddleware, cb ModelStreamCallback) (*ModelResponse, error) { | ||
| func GenerateWithRequest(ctx context.Context, r api.Registry, opts *GenerateActionOptions, mmws []ModelMiddleware, cb ModelStreamCallback) (*ModelResponse, error) { |
There was a problem hiding this comment.
The parameter name mmws is a bit cryptic. While it was likely changed from mw to avoid shadowing, a more descriptive name like modelMiddlewares would improve readability for future maintainers. This change would need to be applied to its usages within this function as well.
| // clone creates a deep copy of the provided object using JSON marshaling and unmarshaling. | ||
| func clone[T any](obj *T) *T { | ||
| if obj == nil { | ||
| return nil | ||
| } | ||
|
|
||
| bytes, err := json.Marshal(obj) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("clone: failed to marshal object: %v", err)) | ||
| } | ||
|
|
||
| var newObj T | ||
| if err := json.Unmarshal(bytes, &newObj); err != nil { | ||
| panic(fmt.Sprintf("clone: failed to unmarshal object: %v", err)) | ||
| } | ||
|
|
||
| return &newObj | ||
| } | ||
|
|
There was a problem hiding this comment.
This comment describes the clone function which has been removed. This dangling comment should be removed to avoid confusion.
1 participant
Checklist (if applicable):