Skip to content

Comments

chore(firebaseai): setup for mock response e2e test#18029

Open
cynthiajoan wants to merge 4 commits intomainfrom
firebaseai/local_integration_test
Open

chore(firebaseai): setup for mock response e2e test#18029
cynthiajoan wants to merge 4 commits intomainfrom
firebaseai/local_integration_test

Conversation

@cynthiajoan
Copy link
Collaborator

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@cynthiajoan cynthiajoan marked this pull request as ready for review February 23, 2026 19:16
@cynthiajoan
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request sets up end-to-end tests for firebase_ai by parsing a suite of mock JSON responses from an external repository. The changes also improve the robustness of the response parsing logic by handling unknown enum values gracefully and making the args field in function calls optional.

The new e2e test is comprehensive and a great addition. I've suggested a couple of enhancements to make it even more robust and complete. Specifically, I recommend failing the test if a mock response file cannot be fetched, and extending the test to cover more response types from the test data repository.

Comment on lines +58 to +60
if (response.statusCode != 200) {
continue;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Silently skipping test files when they can't be fetched (e.g., due to network issues or GitHub API rate limiting) could lead to a false sense of security if tests pass. It would be better to fail the test explicitly to indicate a problem with the test setup or environment.

Suggested change
if (response.statusCode != 200) {
continue;
}
if (response.statusCode != 200) {
fail('Failed to fetch test file $path: ${response.statusCode} ${response.reasonPhrase}');
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants