chore(firebaseai): setup for mock response e2e test#18029
chore(firebaseai): setup for mock response e2e test#18029cynthiajoan wants to merge 4 commits intomainfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request sets up end-to-end tests for firebase_ai by parsing a suite of mock JSON responses from an external repository. The changes also improve the robustness of the response parsing logic by handling unknown enum values gracefully and making the args field in function calls optional.
The new e2e test is comprehensive and a great addition. I've suggested a couple of enhancements to make it even more robust and complete. Specifically, I recommend failing the test if a mock response file cannot be fetched, and extending the test to cover more response types from the test data repository.
| if (response.statusCode != 200) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Silently skipping test files when they can't be fetched (e.g., due to network issues or GitHub API rate limiting) could lead to a false sense of security if tests pass. It would be better to fail the test explicitly to indicate a problem with the test setup or environment.
| if (response.statusCode != 200) { | |
| continue; | |
| } | |
| if (response.statusCode != 200) { | |
| fail('Failed to fetch test file $path: ${response.statusCode} ${response.reasonPhrase}'); | |
| } |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?