JIT: Check for inline candidates in gtTreeContainsAsyncCall#124502
Open
jakobbotsch wants to merge 1 commit intodotnet:mainfrom
Open
JIT: Check for inline candidates in gtTreeContainsAsyncCall#124502jakobbotsch wants to merge 1 commit intodotnet:mainfrom
jakobbotsch wants to merge 1 commit intodotnet:mainfrom
Conversation
Inline candidates can later be substituted for the original call. That call may contain async calls, in which case the standard spilling behavior should kick.
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a JIT code generation bug where async calls within inline candidates were not properly detected, causing incorrect register/memory handling that led to null reference crashes in Native AOT scenarios with runtime async enabled.
Changes:
- Enhanced
gtTreeContainsAsyncCallto recursively check inline candidates withinGT_RET_EXPRnodes for async calls - Updated lambda capture from
[]to[=]to enable the recursive member function call
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline candidates can later be substituted for the original call. That call may contain async calls, in which case the same spilling behavior should kick in.
Fix #124496