Skip to content

compiler: Prevent undefined Temp through global init#2858

Open
mloubout wants to merge 1 commit intomainfrom
alias-multi-cond
Open

compiler: Prevent undefined Temp through global init#2858
mloubout wants to merge 1 commit intomainfrom
alias-multi-cond

Conversation

@mloubout
Copy link
Contributor

@mloubout mloubout commented Feb 25, 2026

See test, basically prevents

    if ((time)%(ctf) == 0)
    {
      const float r0 = cos(time);
    ...
    }
   if (some conditon) {
    ...
    }
   if ((time)%(ctf) == 0){
     u[x] = r0
    }  

and instead in the presence of guards for scalar temps do

    float r0 = 0;
    if ((time)%(ctf) == 0)
    {
      r0 = cos(time);
    ...
    }
   if (some conditon) {
    ...
    }
   if ((time)%(ctf) == 0){
     u[x] = r0
    }  

@mloubout mloubout force-pushed the alias-multi-cond branch 2 times, most recently from 19254fd to 6af1a6b Compare February 25, 2026 16:21
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloubout mloubout changed the title compiler: prevent undefined Temp through global init compiler: Prevent undefined Temp through global init Feb 25, 2026
@mloubout mloubout force-pushed the alias-multi-cond branch 3 times, most recently from e2045e5 to b859dc4 Compare February 25, 2026 17:02
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 24.67532% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.14%. Comparing base (8ad5ec1) to head (5581b6d).

Files with missing lines Patch % Lines
tests/test_dse.py 8.62% 53 Missing ⚠️
devito/passes/clusters/aliases.py 69.23% 2 Missing and 2 partials ⚠️
devito/types/basic.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8ad5ec1) and HEAD (5581b6d). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (8ad5ec1) HEAD (5581b6d)
18 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2858       +/-   ##
===========================================
- Coverage   78.96%   45.14%   -33.83%     
===========================================
  Files         248      248               
  Lines       51089    51158       +69     
  Branches     4422     4425        +3     
===========================================
- Hits        40344    23093    -17251     
- Misses       9937    27130    +17193     
- Partials      808      935      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout mloubout force-pushed the alias-multi-cond branch 3 times, most recently from 10bd3a7 to 169301f Compare February 25, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant