[TS] Improve autogen autocompletion and typing#4309
Open
coolreader18 wants to merge 4 commits intomasterfrom
Open
[TS] Improve autogen autocompletion and typing#4309coolreader18 wants to merge 4 commits intomasterfrom
coolreader18 wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This changes the generated files for product type to be
const Point = t.object(...); export default Point;instead of justexport default t.object(...);, to match sum types. This lets intellisense know that it should be imported asimport Point from ".../point_type.ts", notimport point_type from ".../point_type.ts". It also adds atype Point = Infer<typeof Point>;, so thatPointbecomes both a type and a value, and users/we have to do lessInfer<typeof Point>.Expected complexity level and risk
1
Testing
n/a, no change in behavior.