Skip to content

fix(clerk-js,shared): Do not expect phoneNumber for sendPhoneCode#7869

Open
dstaley wants to merge 3 commits intomainfrom
ds.fix/signup-email-code
Open

fix(clerk-js,shared): Do not expect phoneNumber for sendPhoneCode#7869
dstaley wants to merge 3 commits intomainfrom
ds.fix/signup-email-code

Conversation

@dstaley
Copy link
Member

@dstaley dstaley commented Feb 17, 2026

Description

This PR fixes an issue where the signUp.verifications.sendPhoneCode() method expected a phoneNumber parameter. Since this is part of the sign-up flow where we verify a phone number, we do not want to provide a phone number during the method; the verification attempt will use the phone number that exists on the created sign-up attempt.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added direct phone-code verification actions: send and verify phone codes during sign-up.
  • Bug Fixes

    • Simplified phone verification so sending a code no longer requires providing a phone number parameter, streamlining the sign-up flow.

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: 17b7892

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/chrome-extension Patch
@clerk/expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 17, 2026 11:17pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A changeset was added marking patch releases for two packages. In clerk-js, SignUp gained new SignUpFuturePhoneCode flow methods: sendPhoneCode and verifyPhoneCode, which are bound into SignUpFutureVerifications and exposed via its public type. The shared types removal deleted phoneNumber from SignUpFuturePhoneCodeSendParams. A test that created a signup with a phoneNumber and prepared verification was removed.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(clerk-js,shared): Do not expect phoneNumber for sendPhoneCode' accurately and concisely describes the main change: removing the phoneNumber parameter requirement from sendPhoneCode across the specified packages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7869

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7869

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7869

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7869

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7869

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7869

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7869

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7869

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7869

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7869

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@7869

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7869

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7869

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7869

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7869

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7869

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7869

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7869

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7869

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7869

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7869

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7869

commit: 17b7892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants