Implement cloneGraph method to deep copy an undirected graph#94
Open
Implement cloneGraph method to deep copy an undirected graph#94
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR implements a DFS-based deep copy for LeetCode 133 (“Clone Graph”) in Solution.cloneGraph, using a visited map to avoid duplicating nodes and to handle cycles.
Changes:
- Implemented
cloneGraphusing DFS recursion and avisiteddictionary for memoization. - Renamed the
cloneGraphparameter fromnodetosource.
Comments suppressed due to low confidence (1)
src/graph/clone_graph.py:36
- The docstring still documents the argument as
node, but the method parameter was renamed tosource. Update theArgs:section to match (source: Node - reference to a node in the graph) to avoid misleading readers and tooling.
def cloneGraph(self, source):
"""
Clone an undirected graph.
Args:
node: Node - reference to a node in the graph
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+45
| if not source: | ||
| return | ||
|
|
There was a problem hiding this comment.
For an empty input graph, this returns None (via bare return). The docstring currently says the method returns Node - cloned graph; please clarify in the Returns: section that None is returned when source is None (or explicitly return None for clarity).
ac2a81d to
e8184bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the solution for cloning an undirected graph in the
cloneGraphmethod of theSolutionclass. The method now uses a depth-first search (DFS) approach with a hashmap to track visited nodes, ensuring that each node is cloned only once and that cycles are handled correctly.Implementation of graph cloning:
cloneGraphwith a working DFS-based solution that clones the graph, using avisiteddictionary to avoid duplicating nodes and to handle cycles.nodetosourcefor clarity and consistency throughout the method.