feat: minimal sweep WIF QR implementation#355
Open
otaliptus wants to merge 6 commits intobitcoindevkit:mainfrom
Open
feat: minimal sweep WIF QR implementation#355otaliptus wants to merge 6 commits intobitcoindevkit:mainfrom
otaliptus wants to merge 6 commits intobitcoindevkit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an example WIF sweep with a QR code (or copy-paste a raw WIF string). Given this is an example wallet app, I tried to keep the changes & functionality minimal.
The basic flow is as follows:
Best way to test it is generating a WIF/address and sending some funds there, and sweeping it. Some example transactions on testnet4 can be seen here.
I can also send the WIF of some addresses to Discord, in case you want to try.
Notes to the reviewers
I've tried to work clean here but let me know if you have an alternative implementation/flow in mind please. Also tried to use as much as existing features from BDK & FFI, but open to suggestions.
*Also I was having some problems with launching the wallet upon having an existin
Checklists
All Submissions:
.swift-formatfileNew Features: