Conversation
|
|
||
| <section class="chart-section"> | ||
| <div class="chart-header"> | ||
| <button class="export-btn" onclick={handleExportDAU}> |
There was a problem hiding this comment.
Svelte event handlers should use on:click rather than HTML onclick; as written, these handlers won’t fire reliably (also applies to other buttons in this file and other components).
🤖 React with 👍 or 👎 to let us know if the comment was useful, or 🚀 if it prevented an incident/outage.
| 📥 Export Top 10 | ||
| </button> | ||
| <button class="export-btn secondary" onclick={handleExportAllOrgs}> | ||
| 📥 Export All Orgs |
There was a problem hiding this comment.
The "Export All Orgs" button exports from orgsData, which only contains the top 10 items loaded for the chart, so it won’t export all organizations; the label or data source should reflect this.
🤖 React with 👍 or 👎 to let us know if the comment was useful, or 🚀 if it prevented an incident/outage.
| <section class="stats"> | ||
| <div class="stat-card"> | ||
| <h3>Total Organizations</h3> | ||
| <p class="stat-value">{orgsData.length.toLocaleString()}</p> |
There was a problem hiding this comment.
orgsData.length reflects only the top 10 loaded for the chart, so "Total Organizations" shows 10 rather than the true total; consider using the backend pagination metadata or a separate call.
🤖 React with 👍 or 👎 to let us know if the comment was useful, or 🚀 if it prevented an incident/outage.
| {org.actions.toLocaleString()} | ||
| </div> | ||
| <div class="col-last-active"> | ||
| {new Date(org.lastActiveAt).toLocaleDateString()} |
There was a problem hiding this comment.
new Date(org.lastActiveAt) can produce an invalid or epoch date when lastActiveAt is null (e.g., with TWIST=NULLS); consider guarding and showing a placeholder (also applies to selected org details in App).
🤖 React with 👍 or 👎 to let us know if the comment was useful, or 🚀 if it prevented an incident/outage.
Usage Analytics Submission
Done with Augment.
Checklist
Summary
Brief description of your approach:
Frontend framework:
Pagination strategy:
Key decisions:
Time Spent
Approximately ___ hours
Questions for Discussion
List any questions or areas you'd like to discuss in the follow-up: