Fix DB load not happening after creating first column#2829
Fix DB load not happening after creating first column#2829atharvadeosthale wants to merge 3 commits intomainfrom
Conversation
… fix by moving to centralised location
Console (appwrite/console)Project ID: Tip Schedule functions to run as often as every minute with cron expressions |
WalkthroughThe PR enables invoking the column-creation flow from empty-state views and wires real-time observation into the column creation process. The EmptySheet usage and its header "+" handler were changed to trigger onOpenCreateColumn when mode != 'indexes', and two EmptySheet instances now pass onOpenCreateColumn to open the create-column sheet. The createColumn form now sets up a per-column observer, subscribes to realtime updates filtered to the created column key, awaits a waitPromise to invalidate the table dependency, and ensures observer/unsubscribe cleanup on success or error. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@src/routes/`(console)/project-[region]-[project]/databases/database-[database]/table-[table]/createColumn.svelte:
- Around line 148-193: The promise chain attached to waitPromise in submit() can
surface unhandled rejections because invalidate(Dependencies.TABLE) may throw;
update the chain that starts with waitPromise.then(...) to append a .catch(error
=> { /* log or handle error */ }) that handles errors from invalidate and still
ensures stopObserver cleanup (you can keep the existing .finally(() =>
stopObserver?.()) so cleanup always runs); target the waitPromise.then(async ()
=> await invalidate(Dependencies.TABLE)) section and add a catch referencing
invalidate and Dependencies.TABLE so errors are handled gracefully.

Fix the DB not loading after creating first column. Additionally fixes the (+) icon to now render the slider to create column, which acted like a dead button before
Before

After

Summary by CodeRabbit
New Features
Bug Fixes