fix: prevent infinite loop in _wait_for_finish on persistent 404s#619
Merged
fix: prevent infinite loop in _wait_for_finish on persistent 404s#619
Conversation
… in _wait_for_finish When _wait_for_finish polls a job that consistently returns 404, seconds_elapsed was never updated because the update was only inside the try block on success. This caused the timeout check (seconds_elapsed > DEFAULT_WAIT_WHEN_JOB_NOT_EXIST_SEC) to always evaluate as 0 > 3 = False, spinning the loop indefinitely at 250ms intervals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 42 42
Lines 2482 2482
=======================================
Hits 1887 1887
Misses 595 595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Feb 17, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
I would prefer a fix based on this comment in your other PR, but this works as well:
Contributor
Author
For these last 2.x releases, let's go with this, in the 3.x I will check out your suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_wait_for_finishcould spin indefinitely when polling a non-existent jobseconds_elapsedwas only updated inside thetryblock (on success), so on persistent 404 errors the timeout checkseconds_elapsed > 3always evaluated as0 > 3 = Falseseconds_elapsedupdate into afinallyblock so it is always updated regardless of success or failure (both sync and async variants)Test plan
wait_for_finishon a non-existent run/build ID — should returnNoneafter ~3 seconds instead of looping forever🤖 Generated with Claude Code